RFR: 8326718: Test java/util/Formatter/Padding.java does not timeout on large inputs before JDK-8299677

Raffaello Giulietti rgiulietti at openjdk.org
Tue Feb 27 20:06:52 UTC 2024


On Tue, 27 Feb 2024 19:53:23 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> [JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677) fixes a bug with Formatter.format taking a long time when there is a lot of padding. This test runs Formatter.format with very large padding. Test fails before [JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677) and passes after.
>> 
>> Timeout for the test was set to 10 seconds. Test passes locally with as low as 1 (after [JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677)) and fails as high as 120 (before [JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677)) so it should be consistent.
>
> test/jdk/java/util/Formatter/Padding.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
> 
> Copyright nit: per OpenJDK conventions, the new copyright for the updated file should be "2023, 2024," not just "2024".

Suggestion:

 * Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.

with a `,` after the 2nd year as well. Otherwise a check will fail, as I learned the hard-way ;-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18033#discussion_r1504901855


More information about the core-libs-dev mailing list