Integrated: JDK-8326389: [test] improve assertEquals failure output
Matthias Baesken
mbaesken at openjdk.org
Wed Feb 28 08:39:54 UTC 2024
On Wed, 21 Feb 2024 15:25:36 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> Currently assertEquals has in the failure case sometimes confusing output like :
>
> java.lang.RuntimeException: VM output should contain exactly one RTM locking statistics entry for method compiler.rtm.locking.TestRTMTotalCountIncrRate$Test:🔒 expected 0 to equal 1
> at jdk.test.lib.Asserts.fail(Asserts.java:634)
> at jdk.test.lib.Asserts.assertEquals(Asserts.java:205)
>
> (I don't think we really expected that for some reason 0 equals 1)
> This should be improved.
This pull request has now been integrated.
Changeset: 9b1f1e52
Author: Matthias Baesken <mbaesken at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/9b1f1e5294e130ec444b08af1f73d08e86fd91ee
Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod
8326389: [test] improve assertEquals failure output
Reviewed-by: clanger, jpai
-------------
PR: https://git.openjdk.org/jdk/pull/17952
More information about the core-libs-dev
mailing list