RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used
Matthias Baesken
mbaesken at openjdk.org
Wed Feb 28 12:34:53 UTC 2024
On Fri, 23 Feb 2024 19:18:46 GMT, Christoph Langer <clanger at openjdk.org> wrote:
> The new test JmodExcludedFiles.java checks that no debug symbol files are contained in the jmod files. It does not take into account that with configure option --with-external-symbols-in-bundles=public we want to have stripped pdb files, also in jmods, to get native callstacks with line number.
>
> This modifies the test and checks if equivalent *stripped.pdb files exist when .pdb files are encountered inside jmods. In that case one can assume that --with-external-symbols-in-bundles=public was chosen as configure option.
Looks okay to me, but could we print here `RuntimeException(jmodFile + " is expected not to include native debug symbols` not only the jmod but also the unwanted file(s) ?
-------------
PR Review: https://git.openjdk.org/jdk/pull/17990#pullrequestreview-1906139346
More information about the core-libs-dev
mailing list