RFR: 8310837: Use ByteArrayLittleEndian in java.util.zip [v7]

Lance Andersen lancea at openjdk.org
Wed Feb 28 13:11:54 UTC 2024


On Tue, 16 Jan 2024 16:38:34 GMT, Glavo <duke at openjdk.org> wrote:

>> Using `ByteArrayLittleEndian` is simpler and faster.
>> 
>> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>> 
>> 
>>   Benchmark                     (size)  Mode  Cnt      Score      Error  Units
>> - ZipFileOpen.openCloseZipFile     512  avgt   15  39052.832 ±  107.496  ns/op
>> + ZipFileOpen.openCloseZipFile     512  avgt   15  36275.539 ±  663.193  ns/op
>> - ZipFileOpen.openCloseZipFile    1024  avgt   15  77106.494 ± 4159.300  ns/op
>> + ZipFileOpen.openCloseZipFile    1024  avgt   15  71955.013 ± 2296.050  ns/op
>
> Glavo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add tests

As mentioned earlier, it would be beneficial to measure the potential benefit of this proposed change with ZipFS which has similar albeit slightly different approach to the macros and include as part of this PR of a follow-on PR

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14632#issuecomment-1968951462


More information about the core-libs-dev mailing list