RFR: 8326687: Inconsistent use of "ZIP", "Zip" and "zip" in java.util.zip/jar zipfs javadoc [v2]
Jaikiran Pai
jpai at openjdk.org
Wed Feb 28 14:06:57 UTC 2024
On Tue, 27 Feb 2024 16:15:06 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> This PR updates the javadoc and comments within java.util.zip/jar and zipfs module summary so that it is consistent with the use of "ZIP".
>>
>> In addition, open/src/java.base/share/classes/java/util/zip/package-info.java has been updated to point to the higher level location of the PKWARE APPNOTE.TXT has PKWare recently changed the direct path the the latest version of the spec.
>>
>> It is also worth noting that error messages were not updated as part of the PR and will be updated separately to keep the javadoc changes separate
>
> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>
> Address initial feedback for JDK-8326687
GitHub doesn't allow me to comment on unchanged lines in the PR, but while reviewing this I noticed 2 things:
- It looks like http://www.pkware.com/documents/casestudies/APPNOTE.TXT is now auto redirecting to https://pkware.cachefly.net/webdocs/APPNOTE/APPNOTE-6.3.9.TXT. I'm not sure if its temporary or a permanent thing.
- The other thing is we don't seem to have a `@spec` entry in `src/java.base/share/classes/java/util/zip/package-info.java` pointing to http://www.pkware.com/documents/casestudies/APPNOTE.TXT. We are pointing to ZLIB RFC 1950. Do you think we should add a `@spec` entry to point to http://www.pkware.com/documents/casestudies/APPNOTE.TXT? Of course as a separate PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18011#issuecomment-1969053529
More information about the core-libs-dev
mailing list