RFD: java.util.jar.Manifest.make72Safe has an invalid @deprecation tag

Eirik Bjørsnøs eirbjo at gmail.com
Wed Feb 28 21:39:08 UTC 2024


Hi,

The non-public method java.util.jar.Manifest.make72Safe is marked
@Deprecated(since="13").

However, the Javadoc comment has a '@deprecation' tag which presumably
should have been `@deprecated`.

I first thought of proposing a PR to fix the invalid tag, but then I
noticed that the method is non-public and has no callers in OpenJDK.

Not sure I understand why this internal method was marked deprecated in the
first place and not simply removed? Are we worried about people calling
this reflectively?

What would be the best way to go about this?

(a) Do nothing
(b) Just fix the tag @deprecation -> @deprecated
(c) Fix the tag, add forRemoval=true
(d) Just delete the method altogether (it's internal after all).

Cheers,
Eirik.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20240228/966462a2/attachment.htm>


More information about the core-libs-dev mailing list