RFR: 8324799: Use correct extension for C++ test headers [v2]

Kim Barrett kbarrett at openjdk.org
Thu Feb 29 00:16:29 UTC 2024


On Wed, 28 Feb 2024 14:15:25 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> test/hotspot/jtreg/serviceability/jvmti/vthread/FollowReferences/libVThreadStackRefTest.cpp line 26:
>> 
>>> 24: #include <jni.h>
>>> 25: #include <jvmti.h>
>>> 26: #include <jvmti_common.hpp>
>> 
>> Should this be in quotes rather than <> ?
>
> Suggestion:
> 
> #include "jvmti_common.hpp"

Not making those kinds of changes in this PR.  Also surprised this is using `<atomic>`.  It seems there
are a number of tests doing that.  I'll file a bug for that.
https://bugs.openjdk.org/browse/JDK-8326999

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18035#discussion_r1506821728


More information about the core-libs-dev mailing list