RFR: 8321540: ClassSignature.parseFrom() throws StringIndexOutOfBoundsException for invalid signatures [v2]

[Adam Sotona]

On Tue, 2 Jan 2024 07:17:46 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> I'm guessing you have intentionally not included the original `IndexOutOfBoundsException` as a cause in the `IllegalArgumentException` that gets thrown.

Yes, original exception does not contain any meaningful information.

> Also, it appears that the `SignaturesImpl` is more like an utility class and isn't expected to be used in multi-thread access and thus the reliance on the (non final) instance field `sig` appears OK.

Right, `SignaturesImpl` instance is never exposed for multi-threaded access.

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17058#issuecomment-1873974280