Blessed modifier order does not include sealed/non-sealed

Roger Riggs roger.riggs at oracle.com
Tue Jan 2 14:38:54 UTC 2024


Hi Pavel,

yes, a PR would be next.

Happy New Year, Roger

On 1/2/24 7:08 AM, Pavel Rappo wrote:
> I assume the order for `sealed` and `non-sealed` has effectively been decided by JLS: https://docs.oracle.com/javase/specs/jls/se21/html/jls-8.html#jls-8.1.1
>
>      8.1.1. Class Modifiers
>      ...
>      
>      ClassModifier:
>      (one of)
>      Annotation public protected private
>      abstract static final sealed non-sealed strictfp
>      
>      ...
>
>      If two or more (distinct) class modifiers appear in a class declaration, then it is customary, though not required, that they appear in the order consistent with that shown above in the production for ClassModifier.
>
>
> Shall I just create a PR?
>
>> On 2 Jan 2024, at 11:56, Pavel Rappo <pavel.rappo at oracle.com> wrote:
>>
>> I couldn't find any prior discussions on this matter.
>>
>> I noticed that bin/blessed-modifier-order.sh has not been updated for the [recently introduced](https://openjdk.org/jeps/409) `sealed` and `non-sealed` keywords. I also note that we already have cases in OpenJDK where those keywords are ordered differently. If we have a consensus on how to extend the "blessed order" onto those new keywords, I can create a PR to update the script.
>>
>> -Pavel
>>



More information about the core-libs-dev mailing list