RFR: 8322802: Add testing for ZipFile.getEntry respecting the 'Language encoding' flag [v4]

Eirik Bjørsnøs eirbjo at openjdk.org
Tue Jan 2 17:21:13 UTC 2024


On Tue, 2 Jan 2024 16:43:29 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add more cases for 'language encoding' bit set, opened with a different encoding
>
> test/jdk/java/util/zip/ZipCoding.java line 130:
> 
>> 128:             assertEquals(name, e.getName());
>> 129:             assertNull(e.getComment()); // No comment in the LOC header
>> 130:             assertArrayEquals(ENTRY_DATA, zis.readAllBytes(), "ZipIS content doesn't match!");
> 
> Minor Nit, but perhaps changes the "ZipIS content..." message to make it clearer as it is not what is clear what ZipIS is...

These messages were mostly carried over. I updated this one to "ZIP entry data does not match". Also updated a few other assertion messages.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17207#discussion_r1439654471


More information about the core-libs-dev mailing list