RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted [v16]

Brian Burkhalter bpb at openjdk.org
Tue Jan 2 18:08:49 UTC 2024


On Thu, 21 Dec 2023 17:29:16 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Sergey Tsypanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision:
>> 
>>  - 8322292: Remove TransferToTrusted.checkedOutputStream()
>>  - 8320971: Adjust JavaDoc
>>  - Merge branch 'master' into 8320971
>>  - 8320971: Revert irrelevant changes
>>  - 8320971: Add more tests
>>  - 8320971: Fix JavaDoc
>>  - 8320971: Whitespaces
>>  - 8320971: Fix build
>>  - 8320971: Move IOStreams to com.sun.io
>>  - Merge branch 'master' into 8320971
>>  - ... and 10 more: https://git.openjdk.org/jdk/compare/aed73e30...84686bc6
>
> The test does not fail when run against the mainline (HEAD: Thu Dec 21 15:20:01 2023 +0000 UTC). As previously mentioned elsewhere, normally a deterministic test should fail before the proposed source patch is applied, and succeed thereafter.

> @bplb has been reviewing the test, I'll stay out of that and let Brian finish his review.

I think that the test looks all right, but the copyright might need to be changed to `2023, 2024` instead of just `2023` as it is a new file. The source file does not need `2024` if no changes have been made in the last two days.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16879#issuecomment-1874366815


More information about the core-libs-dev mailing list