RFR: 8322322: Support archived full module graph when -Xbootclasspath/a is used [v3]
Mandy Chung
mchung at openjdk.org
Thu Jan 4 18:37:23 UTC 2024
On Wed, 3 Jan 2024 00:49:01 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Please review this change for enabling full module graph even when -Xbootclasspath/a is specified. The validation of -Xbootclasspath/a is already being done in `FileMapInfo::validate_boot_class_paths()`. The full module graph will be disabled if there's a mismatch in -Xbootclasspath/a between dump time and runtime.
>>
>> The changes in ClassLoaders.java is for setting up the append class path for the boot loader retrieved from the CDS archive. It is required because some existing tests are using the `getResourceAsStream()` api. Those tests would fail without the change.
>>
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>
> tests update per discussion with Ioi
Looks okay to me.
-------------
Marked as reviewed by mchung (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17178#pullrequestreview-1804764896
More information about the core-libs-dev
mailing list