RFR: 8321786: SegmentAllocator:allocateFrom(ValueLayout, MemorySegment, ValueLayout, long, long) spec mismatch in exception scenario [v10]

Per Minborg pminborg at openjdk.org
Fri Jan 5 08:36:56 UTC 2024


> This PR proposes to change the specification for some methods that take `long` offsets so that they will throw an `IllegalArgumentException` rather than an `IndexOutOfBoundsException` for negative values.
> 
> The PR also proposes to fix a bug where the allocation size would overflow and the specified exception was not thrown.

Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:

 - Merge branch 'master' into throw-change2
 - Fix docs for read-only exceptions
 - Fix formatting in test
 - Move @throws tag
 - Correct exception type in JavaDocs for SA:allocateFrom
 - Update after comments
 - Revert change in allocateNoInit
 - Remove Math.multiply exact and change exception type
 - Update after comments and discussion
 - Change the exception thrown for certain negative long values

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17079/files
  - new: https://git.openjdk.org/jdk/pull/17079/files/4d7c58ad..7d5472c5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17079&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17079&range=08-09

  Stats: 8635 lines in 594 files changed: 5231 ins; 1384 del; 2020 mod
  Patch: https://git.openjdk.org/jdk/pull/17079.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17079/head:pull/17079

PR: https://git.openjdk.org/jdk/pull/17079


More information about the core-libs-dev mailing list