RFR: 8323183: ClassFile API performance improvements

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Jan 8 14:17:24 UTC 2024


On Mon, 8 Jan 2024 14:14:29 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> ClassFile API performance related improvements have been separated from #17121 into this PR.
>> 
>> These improvements are important to minimize performance regression of
>> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes #17121
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java line 367:
> 
>> 365:                         if (subReturn) {
>> 366:                             return switch (descriptor.charAt(cur++)) {
>> 367:                                 case 'Z', 'B', 'C', 'S', 'I', 'F', '[', 'L' -> count - 1;
> 
> What if the return type is an array?

Ah nvm, I see you subtract -1 there

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17306#discussion_r1444712392


More information about the core-libs-dev mailing list