RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v7]
Adam Sotona
asotona at openjdk.org
Mon Jan 8 14:21:26 UTC 2024
On Fri, 5 Jan 2024 20:50:16 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>>
>> StackCounter fix
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 135:
>
>> 133: var cc = ClassFile.of();
>> 134: var entries = new ArrayList<PoolEntry>(20);
>> 135: var q = new Object() {
>
> It'd be helpful to add a comment to explain what this optimization is doing.
Yes, I'll add an explanation comment, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17121#discussion_r1444717838
More information about the core-libs-dev
mailing list