RFR: 8323183: ClassFile API performance improvements [v3]

Adam Sotona asotona at openjdk.org
Mon Jan 8 16:12:51 UTC 2024


On Mon, 8 Jan 2024 14:20:17 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   applied suggested changes
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java line 417:
> 
>> 415:                 bcs.bci,
>> 416:                 methodName,
>> 417:                 MethodTypeDesc.ofDescriptor(methodDesc.stringValue()).displayDescriptor()));
> 
> This seems unrelated?

methodDesc is newly an Utf8Entry, so it needs to be converted to throw with the same message

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17306#discussion_r1444917187


More information about the core-libs-dev mailing list