RFR: 8318971: Better Error Handling for Jar Tool Processing of "@File" [v5]

Jaikiran Pai jpai at openjdk.org
Tue Jan 9 10:11:29 UTC 2024


On Tue, 28 Nov 2023 12:18:23 GMT, Ryan Wallace <duke at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this fix for jar tool not producing an archive if there is a missing file supplied.
>> The current behaviour will recognise missing files as an error but continue processing,
>> creating a temporary archive and then deleting it without moving to the current directory.
>> The fix is to return false when a missing file is supplied and exit immediately without continuing with any wasted processing.
>> 
>> Thanks,
>> Ryan.
>
> Ryan Wallace has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Merge branch 'master' into 8318971
>  - 8318971: Better Error Handling for Jar Tool Processing of "@File"
>  - Merge branch 'master' into 8318971
>  - Merge branch 'master' into 8318971
>  - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
>  - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
>  - Merge branch 'master' into 8318971
>  - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
>  - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

This has been replaced by https://github.com/openjdk/jdk/pull/17088

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16423#issuecomment-1882772352


More information about the core-libs-dev mailing list