RFR: 8322565 (zipfs) Files.setPosixPermissions should preserve 'external file attributes' bits [v2]
Eirik Bjørsnøs
eirbjo at openjdk.org
Wed Jan 10 10:35:25 UTC 2024
On Tue, 9 Jan 2024 22:08:20 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Verify that ZipFileSystem preserves 'external file attribute' bits when performing operations unrelated to POSIX, such as Files.setLastModifiedTime.
>> - Merge branch 'master' into zipfs-preserve-external-file-attrs
>> - Preserve non-permission 'external file attributes' bits when setting posix permissions
>
> Looks correct to me, too. I also went over the changes to the test and it makes sense.
Thanks to @RealCLanger for the review and to @AlanBateman for the nod.
I'll let this linger a bit before integrating in case @LanceAndersen still wants to take a look.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17170#issuecomment-1884585790
More information about the core-libs-dev
mailing list