RFR: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile [v7]

[Lance Andersen]

On Fri, 15 Dec 2023 11:15:30 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Seeing that `ReadAfterClose.java` uses a binary test vector `crash.jar`, I think it makes sense to include it in this PR, convert it to JUnit and move it into `ReadZip.readAfterClose`.
>> 
>> This removes the last remaining binary test vector ZIP in the `ZipFile/` directory.
>
>> Seeing that `ReadAfterClose.java` uses a binary test vector `crash.jar`, I think it makes sense to include it in this PR, convert it to JUnit and move it into `ReadZip.readAfterClose`.
>> 
>> This removes the last remaining binary test vector ZIP in the `ZipFile/` directory.
> 
> These are on my list to review, thank you for the update.
> 
> One comment, for the tests that we are removing/retiring, we probably want to include the bug numbers and/or the name of the original test class in the new home for the tests to  make it easier for future maintainers to chase back the history in the unlikely event that an issue arises...

> Thanks for your review, @LanceAndersen!
> 
> You might want to take a quick look at the lastest updates addressing your review before I integrate.

Looks good.  I am running mach5 tiers1-3 internally once it completes, I will approve again

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17038#issuecomment-1885761673