RFR: JDK-8322235: Split up and improve LocaleProvidersRun [v4]

Justin Lu jlu at openjdk.org
Wed Jan 10 21:36:49 UTC 2024


> Please review this PR which splits up the _LocaleProvidersRun_ test file for performance and maintenance reasons.
> 
> _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR, HOST, SPI, etc.) was getting rather long, as all related bugs were added to the single test file. To improve maintainability, this change splits up the single test file into separate test files focused on specific areas (ex: _j.text.Format_).  The original _LocaleProvidersRun_ test file remains and is used for more general Locale Provider testing such as the adapter loading.
> 
> In addition, the previously single test file used to suffer from performance issues, as each test method had to launch a new JVM (since Locale Providers are set at Java startup time). With this change, these tests files can be ran with VM flags and not cause timeout, thus `@requires vm.flagless` is no longer needed (Tiers 6-8 tested).
> 
> Other updates
> - For OS/locale specific tests, the OS/locale is now checked before (not after) launching a JVM
> - Added comments for each test method

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  copyright year for HLPA_md.c

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17257/files
  - new: https://git.openjdk.org/jdk/pull/17257/files/c754893f..a619b255

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17257&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17257&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17257.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17257/head:pull/17257

PR: https://git.openjdk.org/jdk/pull/17257


More information about the core-libs-dev mailing list