RFR: JDK-8322979: Add informative discussion to Modifier [v2]

Alan Bateman alanb at openjdk.org
Thu Jan 11 09:41:24 UTC 2024


On Wed, 10 Jan 2024 10:17:10 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implement review feedback.
>
> src/java.base/share/classes/java/lang/reflect/Modifier.java line 238:
> 
>> 236:      * modifiers of a class or member, source-level modifiers that do
>> 237:      * not <em>not</em> have a constant in the this class should be
>> 238:      * included and ordered consistent with the full recommended
> 
> Suggestion:
> 
>      * included and ordered consistently with the full recommended

Yes, "ordered consistently with" or "with order consistent with", I think both will work here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17338#discussion_r1448564687


More information about the core-libs-dev mailing list