RFR: 8323571: Regression in source resolution process

Naoto Sato naoto at openjdk.org
Thu Jan 11 20:38:29 UTC 2024


On Thu, 11 Jan 2024 18:36:39 GMT, Joe Wang <joehw at openjdk.org> wrote:

> Fix a regression in the source resolution process where it failed to recognize a custom InputSource when both the public and system IDs are null. The particular issue is fixed at line 1233, the rest of the changes is formatting to make the null-check on InputSource the first.
> 
> Test is provided by Marc, thanks Marc! (https://github.com/junit-team/junit5/issues/3594)
> 
> XML tests, including the new test, pass with this change.

LGTM. If the file was modified this year, put 2024 in the header

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17377#pullrequestreview-1816602664


More information about the core-libs-dev mailing list