Integrated: 8323529: Relativize test image dependencies in microbenchmarks

Claes Redestad redestad at openjdk.org
Fri Jan 12 10:03:29 UTC 2024


On Wed, 10 Jan 2024 15:10:58 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> JMH microbenchmarks may have dependencies on artifacts in the test image outside of the benchmarks.jar. This includes native libraries (built into `$TEST_IMAGE/micro/native`) and may soon include other test libraries like wb.jar (built into `$TEST_IMAGE/lib-test/`)
> 
> By moving execution to the test image root (currently we run out of the `make` directory) we can make do with relative paths, which means benchmark can supply a build-time constant flag themselves rather than have the test runner provide it for you. And needing to be explicit about external dependencies is good, I think.
> 
> Taken together this makes the benchmarks.jar more self-contained and simpler to run: all you need is to run `java -jar micro/benchmarks.jar` from the test image root.
> 
> This patch also drive-by fixes some lang.foreign tests that were printing warnings due to a missing `--enable-native-access=ALL-UNNAMED` flag.

This pull request has now been integrated.

Changeset: 3e19bf88
Author:    Claes Redestad <redestad at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3e19bf88d5b51fe10c183f930b99bce961a368c1
Stats:     21 lines in 17 files changed: 5 ins; 0 del; 16 mod

8323529: Relativize test image dependencies in microbenchmarks

Reviewed-by: mcimadamore, jvernee, erikj

-------------

PR: https://git.openjdk.org/jdk/pull/17349


More information about the core-libs-dev mailing list