RFR: 8323562: SaslInputStream.read() may return wrong value
Aleksey Shipilev
shade at openjdk.org
Fri Jan 12 11:46:19 UTC 2024
On Thu, 11 Jan 2024 06:28:51 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
> SaslInputStream.read() should return a value in the range from 0 to 255 per the spec of InputStream.read() but it returns the signed byte from the inBuf as is.
Looks fine. I think the common style is to use capitalized `0xFF`, but that one is not enforced consistently. This will do as well.
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17365#pullrequestreview-1818007975
More information about the core-libs-dev
mailing list