RFR: 8323621: JDK build should exclude snippet class in java.lang.foreign

[Magnus Ihse Bursie]

On Sun, 14 Jan 2024 04:07:29 GMT, Chen Liang <liach at openjdk.org> wrote:

>> make/modules/java.base/Java.gmk line 41:
>> 
>>> 39:     java/lang/classfile/snippet-files \
>>> 40:     java/lang/classfile/components/snippet-files \
>>> 41:     jdk/lang/foreign/snippet-files
>> 
>> I can't find this directory in the source tree, but there is a `src/java.base/share/classes/java/lang/foreign/snippet-files`. Is that what you want to exclude?
>
> If possible, we should simply exclude all files in directories that have `-` (minus sign) in their name; this is the intentional design to prevent javac from compiling those classes as package names cannot include `-`.

I agree that this piecemeal approach is not good. I think there is a JBS enhancement request to filter all "snippet-files" and "javadoc-files" everywhere. But maybe we can make it broader? Filtering on just `-` makes me a bit nervous though; it seems like it could unintentionally break at some point. But maybe filter out all `-files`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17403#discussion_r1452377059