RFR: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin
Richard Reingruber
rrich at openjdk.org
Wed Jan 17 09:37:20 UTC 2024
On Tue, 16 Jan 2024 10:57:46 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for correct (Dekker scheme) synchronization with concurrent execution of [`AbstractInterruptibleChannel::begin`](https://github.com/openjdk/jdk/blob/59062402b9c5ed5612a13c1c40eb22cf1b97c41a/src/java.base/share/classes/java/nio/channels/spi/AbstractInterruptibleChannel.java#L176).
>
> The change passed our CI functional testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests.
> Testing was done with fastdebug and release builds on the main platforms and also on Linux/PPC64le and AIX.
Thanks for the test @AlanBateman
The new test LotsOfInterrupts.java hangs after a few repetitions (using jtreg's REPEAT_COUNT). With the fix it always terminates successfully.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17444#issuecomment-1894154593
PR Comment: https://git.openjdk.org/jdk/pull/17444#issuecomment-1894211061
More information about the core-libs-dev
mailing list