RFR: 8323794: Remove unused jimage compressor plugin configuration [v5]
Claes Redestad
redestad at openjdk.org
Wed Jan 17 10:53:50 UTC 2024
On Wed, 17 Jan 2024 10:41:07 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> There's an unused concept of a pluginConfig that is passed into the jlink compress plugins, however we always pass null here and the code seems broken (the pluginConfig wouldn't have been stored properly). This seem to be a left-over from a more generic plugin design that never came to fruition.
>>
>> This PR cleans out this code from the plugins and decompressors, while keeping the compressed header format intact for backwards compatibility (and in case we want to revisit this in the future)
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>
> Missed a Properties argument in CompressorPluginTest
Thanks for reviewing and re-reviewing! I caught and fixed a few issues in testing (tier1-4), extending pre-integration testing to tier5 and taking another manual pass over all related tests before integrating.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17443#issuecomment-1895560774
More information about the core-libs-dev
mailing list