RFR: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin [v2]
Christoph Langer
clanger at openjdk.org
Wed Jan 17 21:20:55 UTC 2024
On Wed, 17 Jan 2024 15:38:22 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for correct (Dekker scheme) synchronization with concurrent execution of [`AbstractInterruptibleChannel::begin`](https://github.com/openjdk/jdk/blob/59062402b9c5ed5612a13c1c40eb22cf1b97c41a/src/java.base/share/classes/java/nio/channels/spi/AbstractInterruptibleChannel.java#L176).
>>
>> The change passed our CI functional testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests.
>> Testing was done with fastdebug and release builds on the main platforms and also on Linux/PPC64le and AIX.
>
> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>
> Review Alan
test/jdk/java/nio/channels/Selector/LotsOfInterrupts.java line 2:
> 1: /*
> 2: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
I guess you should credit SAP here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17444#discussion_r1456496044
More information about the core-libs-dev
mailing list