RFR: 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static [v2]

[Patricio Chilano Mateo]

On Thu, 11 Jan 2024 13:09:39 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> The notification method `VirtualThread.notifyJvmtiDisableSuspend` should be static.
>> The method disables/enables suspend of the current virtual thread, a no-op if the current thread is a platform thread. It is confusing for this to be an instance method, it should be static to make it clearer that it doesn't change the target thread.
>> The notification method `VirtualThread.notifyJvmtiHideFrames` also has to be static as it does not use/need the virtual thread `this` argument.
>> One detail to underline is the intrinsic implementation needs to use the argument #0 instead of #1.
>> 
>> Testing:
>> - The mach5 tiers 1-6 show no regressions
>
> Serguei Spitsyn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge
>  - 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static

Looks good to me. I'm confused about the description saying this method is a no-op if the current thread is a platform thread.

-------------

Marked as reviewed by pchilanomate (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17298#pullrequestreview-1832725029