Integrated: 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static

Serguei Spitsyn sspitsyn at openjdk.org
Fri Jan 19 18:43:39 UTC 2024


On Mon, 8 Jan 2024 07:55:45 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> The notification method `VirtualThread.notifyJvmtiDisableSuspend` should be static.
> The method disables/enables suspend of the current virtual thread, a no-op if the current thread is a platform thread. It is confusing for this to be an instance method, it should be static to make it clearer that it doesn't change the target thread.
> The notification method `VirtualThread.notifyJvmtiHideFrames` also has to be static as it does not use/need the virtual thread `this` argument.
> One detail to underline is the intrinsic implementation needs to use the argument #0 instead of #1.
> 
> Testing:
> - The mach5 tiers 1-6 show no regressions

This pull request has now been integrated.

Changeset: 8700de66
Author:    Serguei Spitsyn <sspitsyn at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8700de66e45b526958c7a2923d43abe2a736d1d2
Stats:     14 lines in 5 files changed: 0 ins; 0 del; 14 mod

8322744: VirtualThread.notifyJvmtiDisableSuspend should be static

Reviewed-by: pchilanomate, alanb

-------------

PR: https://git.openjdk.org/jdk/pull/17298


More information about the core-libs-dev mailing list