RFR: JDK-8323186: A faster algorithm for MutablebigInteger.divWord(long, int) [v3]
fabioromano1
duke at openjdk.org
Mon Jan 22 15:36:27 UTC 2024
On Mon, 22 Jan 2024 15:14:58 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:
>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed trailing whitespaces
>
> The test does not seem to check that the results are correct, but just measures elapsed time.
>
> For this, in the context of the OpenJDK, we use [JMH](https://github.com/openjdk/jmh) for performance benchmarks. It avoids all the common issues with less sophisticated approaches. At first, it might seem harder to use, but it is more reliable than ad-hoc measurements. While not perfect, it has established itself as the "golden standard", so to say.
@rgiulietti The correctness of the algorithm simply follows by the fact that it is just a particularization of `Long.divideUnsigned(long, long)` and `Long.remainderUnsigned(long, long)`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17291#issuecomment-1904256641
More information about the core-libs-dev
mailing list