RFR: 8323717: Introduce test keyword for tests that need external dependencies

David Holmes dholmes at openjdk.org
Tue Jan 23 01:35:27 UTC 2024


On Mon, 15 Jan 2024 10:48:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Some jtreg tests require resolvable external dependencies. This resolution is delegated to JIB, which is not used in vanilla OpenJDK testing. It would be convenient to add a keyword that marks tests that require these external dependencies, so that we could exclude those tests from runs. This would allow us to: a) run all tests in hotspot:tier4, which now excludes `applications/` specifically; b) make all tests runs (#17422) cleaner on many environments.
> 
> I provisionally call this flag `external-dep`, but I am open for other suggestions.
> 
> Note that some tests that pull `@Artifact`-s provide special paths that do limited testing anyway. However, there are tests which cannot run without external dependencies at all. These include at least `applications/jcstress` and `applications/scimark` tests.
> 
> Ironically, I cannot run the jcstress test generator because the dependencies are lacking here. I regenerated those test using a self-built jcstress 0.16 bundle.
> 
> Additional testing:
>  - [x] `make test TEST=applications/` fails
>  - [x]  `JTREG_KEYWORDS=!external-dep make test TEST=applications/` passes, skipping most of the tests

Seems quite reasonable.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17421#pullrequestreview-1837713758


More information about the core-libs-dev mailing list