Integrated: JDK-8321545: Override toString() for Format subclasses
Justin Lu
jlu at openjdk.org
Tue Jan 23 22:25:41 UTC 2024
On Wed, 10 Jan 2024 21:05:38 GMT, Justin Lu <jlu at openjdk.org> wrote:
> Please review this PR which implements toString() for the `Format` subclasses. Corresponding CSR: [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088)
>
> The general specification follows a template that provides the locale (if the class is localized) and any relevant patterns. The specification was intentionally kept minimal and deliberately worded as "for debugging".
>
> An example of all the classes has output such as
>
>
> CompactNumberFormat [locale: "English (United States)", decimal pattern: "foo#0.00#baz", compact patterns: "[, , , {one:0K other:0K}, {one:00K other:00K}, {one:000K other:000K}, {one:0M other:0M}, {one:00M other:00M}, {one:000M other:000M}, {one:0B other:0B}, {one:00B other:00B}, {one:000B other:000B}, {one:0T other:0T}, {one:00T other:00T}, {one:000T other:000T}]"]
>
> DecimalFormat [locale: "English (United States)", pattern: "foo#0.00#baz"]
>
> SimpleDateFormat [locale: "Chinese (China)", pattern: "EEE, MMM d, ''yy"]
>
> ListFormat [locale: "English (United States)", start: "{0}, {1}", middle: "{0}, {1}", end: "{0}, and {1}", two: "{0} and {1}", three: "{0}, {1}, and {2}"]
>
> MessageFormat [locale: "Chinese (China)", pattern: "foo {0}"]
>
> ChoiceFormat [pattern: "0#foo"]
This pull request has now been integrated.
Changeset: 96607df7
Author: Justin Lu <jlu at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/96607df7f055a80d56ea4c19f3f4fcb32838b1f8
Stats: 419 lines in 12 files changed: 412 ins; 0 del; 7 mod
8321545: Override toString() for Format subclasses
Reviewed-by: naoto, rriggs
-------------
PR: https://git.openjdk.org/jdk/pull/17355
More information about the core-libs-dev
mailing list