RFR: 8323699: MessageFormat.toPattern() generates non-equivalent MessageFormat pattern [v3]

[Archie Cobbs]

On Tue, 23 Jan 2024 23:00:29 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> src/java.base/share/classes/java/text/MessageFormat.java line 556:
>> 
>>> 554:      * does not necessarily equal the previously applied pattern.
>>> 555:      *
>>> 556:      * @implNote The string returned by this method can be used to create
>> 
>> Hmm, I'm not sure about the current note, because its not true in all cases (for example, some unknown subclass of Format). Maybe @naotoj has thoughts?
>
> Yes, my comment to the CSR was to explain the default implementation as the `@implNote`. Making it explicit would be helpful to readers.

Yes my mistake, I'll change this to:

@implNote The implementation in {@link MessageFormat} returns a string
that can be used to create a new instance that is semantically equivalent
to this instance.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17416#discussion_r1464104922