RFR: 8324433: Introduce a way to determine if an expression is evaluated as a constant by the Jit compiler [v5]

Quan Anh Mai qamai at openjdk.org
Wed Jan 24 10:40:27 UTC 2024


On Wed, 24 Jan 2024 09:03:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> That sounds like a better name for the class, although I think `jdk.internal.misc` is more suitable than `jdk.internal.vm`. Do you have any preference? Thanks.
>
> +1 to `ConstantSupport`. I think `jdk.internal.vm` is a proper place for it. There is adjacent `jdk.internal.vm.vector.VectorSupport`, and whole `jdk.internal.vm.annotations` package is there too.
> 
> `jdk.internal.misc` sounds like a place for utility classes. `Unsafe` is a historical exception, I think.

I see, my main premise is that it is somewhat similar to `Unsafe` which turns out to be an exception :) Thanks a lot for your suggestions, I have updated the PR, also added `@Hidden` back.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17527#discussion_r1464707689


More information about the core-libs-dev mailing list