RFR: 8303374: Implement JEP 455: Primitive Types in Patterns, instanceof, and switch (Preview) [v42]
Aggelos Biboudis
abimpoudis at openjdk.org
Wed Jan 24 15:26:57 UTC 2024
On Wed, 24 Jan 2024 12:13:23 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Set previewEnabled properly in SwitchBootstraps
>
> src/java.base/share/classes/java/lang/runtime/ExactConversionsSupport.java line 37:
>
>> 35: * action at run time.
>> 36: * <p>
>> 37: * The run time conversion checks examine whether loss of information would
>
> You provide examples for runtime conversions - it would be useful, before this para, to also have examples of an inexact conversion, an exact conversion and an unconditionally exact conversion (before diving into the details of how the runtime check is performed for floating points).
Addressed in https://github.com/openjdk/jdk/pull/15638/commits/5e48ea253bb7d8ae6fcc15a1ae7adb30475ff4ac
Good point!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1465080703
More information about the core-libs-dev
mailing list