RFR: 8303374: Implement JEP 455: Primitive Types in Patterns, instanceof, and switch (Preview) [v45]

Joe Darcy darcy at openjdk.org
Wed Jan 24 18:23:38 UTC 2024


On Wed, 24 Jan 2024 18:14:11 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

> I have this regarding numeric values. Is it the kind of test you have in mind?
> 
> [test/langtools/tools/javac/patterns/PrimitiveInstanceOfNumericValueTests.java](https://github.com/openjdk/jdk/pull/15638/files#diff-0c7b37309d920b4c1af93789aed337c9eb259ad31977b9ef395e7b8c4b47a6d6)

IMO, the library methods merit some of their own dedicated direct testing (since an end user could in principle call them too) in addition to indirect tests of their operation via javac's code generation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1465371034


More information about the core-libs-dev mailing list