RFR: 8303374: Implement JEP 455: Primitive Types in Patterns, instanceof, and switch (Preview) [v45]

Vicente Romero vromero at openjdk.org
Wed Jan 24 18:31:43 UTC 2024


On Wed, 24 Jan 2024 15:55:51 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> This is the proposed patch for Primitive types in patterns, instanceof, and switch (Preview).
>> 
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove redundant test from checkUnconditionallyExact

test/langtools/tools/javac/patterns/PrimitiveInstanceOfPatternOpWithRecordPatterns.java line 28:

> 26:  * @bug 8304487
> 27:  * @summary Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview)
> 28:  * @compile -g --enable-preview -source ${jdk.version} PrimitiveInstanceOfPatternOpWithRecordPatterns.java

not sure why you need `-g` here

test/langtools/tools/javac/patterns/PrimitiveInstanceOfTypeComparisonOp.java line 28:

> 26:  * @bug 8304487
> 27:  * @summary Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview)
> 28:  * @compile -g --enable-preview -source ${jdk.version} PrimitiveInstanceOfTypeComparisonOp.java

`-g`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1465376609
PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1465378575


More information about the core-libs-dev mailing list