RFR: 8303374: Implement JEP 455: Primitive Types in Patterns, instanceof, and switch (Preview) [v50]

Maurizio Cimadamore mcimadamore at openjdk.org
Thu Jan 25 10:18:39 UTC 2024


On Wed, 24 Jan 2024 23:50:51 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> This is the proposed patch for Primitive types in patterns, instanceof, and switch (Preview).
>> 
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update year

src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 592:

> 590:                                     element.caseLabel() instanceof Double ||
> 591:                                     element.caseLabel() instanceof Boolean)) {
> 592:                             //TODO: should call equals on the constant, not on the selector, check

Looking at the code, it seems like we're already calling equals on the constant? (I assume that's to avoid spurious NPEs?)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1466143827


More information about the core-libs-dev mailing list