RFR: JDK-8324598: use mem_unit when working with sysinfo memory and swap related information [v2]

Martin Doerr mdoerr at openjdk.org
Thu Jan 25 10:22:27 UTC 2024


On Thu, 25 Jan 2024 09:15:38 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> According to the sysinfo manpage ( https://man7.org/linux/man-pages/man2/sysinfo.2.html ) the memory and swap related entries in the struct sysinfo are given as multiples of mem_unit bytes.
>> "In the above structure, sizes of the memory and swap fields are given as multiples of mem_unit bytes."
>> 
>> This is considered in most parts of the OpenJDK codebase when sysinfo is used but not all; should be added where it is missing.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add parentheses

I would have preferred the original version, but it's ok either way.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17550#pullrequestreview-1843336972


More information about the core-libs-dev mailing list