RFR: 8303374: Implement JEP 455: Primitive Types in Patterns, instanceof, and switch (Preview) [v50]

Aggelos Biboudis abimpoudis at openjdk.org
Thu Jan 25 11:21:12 UTC 2024


On Thu, 25 Jan 2024 10:21:26 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update year
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 404:
> 
>> 402:      */
>> 403:     @SuppressWarnings("removal")
>> 404:     private static MethodHandle generateInnerClass(MethodHandles.Lookup caller, Class<?> selectorType, Object[] labels) {
> 
> I think the name "labels" for the array here is unfortunate, because the code generation also contains "labels" which mean really "jump targets". Maybe `constants` or `labelConstants` or `caseConstants` ?

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1466217507


More information about the core-libs-dev mailing list