RFR: 8303374: Implement JEP 455: Primitive Types in Patterns, instanceof, and switch (Preview) [v45]

Aggelos Biboudis abimpoudis at openjdk.org
Thu Jan 25 11:21:13 UTC 2024


On Wed, 24 Jan 2024 17:29:09 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove redundant test from checkUnconditionallyExact
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 405:
> 
>> 403:      */
>> 404:     @SuppressWarnings("removal")
>> 405:     private static MethodHandle generateInnerClass(MethodHandles.Lookup caller, Class<?> selectorType, Object[] labels) {
> 
> again a matter of style but it seems to me that the huge lambda inside of this method, starting in line 409, really wants to be a separate helper method. That will probably be a better refactoring as we won't be mixing byte code generation with method handles manipulation.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1466217863


More information about the core-libs-dev mailing list