RFR: 8323717: Introduce test keyword for tests that need external dependencies

Leonid Mesnik lmesnik at openjdk.org
Thu Jan 25 17:00:38 UTC 2024


On Wed, 24 Jan 2024 21:28:29 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Some jtreg tests require resolvable external dependencies. This resolution is delegated to JIB, which is not used in vanilla OpenJDK testing. It would be convenient to add a keyword that marks tests that require these external dependencies, so that we could exclude those tests from runs. This would allow us to: a) run all tests in hotspot:tier4, which now excludes `applications/` specifically; b) make all tests runs (#17422) cleaner on many environments.
>> 
>> I provisionally call this flag `external-dep`, but I am open for other suggestions.
>> 
>> Note that some tests that pull `@Artifact`-s provide special paths that do limited testing anyway. However, there are tests which cannot run without external dependencies at all. These include at least `applications/jcstress` and `applications/scimark` tests.
>> 
>> Ironically, I cannot run the jcstress test generator because the dependencies are lacking here. I regenerated those test using a self-built jcstress 0.16 bundle.
>> 
>> Additional testing:
>>  - [x] `make test TEST=applications/` fails
>>  - [x]  `JTREG_KEYWORDS=!external-dep make test TEST=applications/` passes, skipping most of the tests
>
> Marked as reviewed by lmesnik (Reviewer).

> @lmesnik, you good with the keyword name?

Yes, I'm fine.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17421#issuecomment-1910613276


More information about the core-libs-dev mailing list