RFR: 8323835: Updating ASM to 9.6 for JDK 23

Vicente Romero vromero at openjdk.org
Fri Jan 26 01:04:33 UTC 2024


On Tue, 16 Jan 2024 21:18:55 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> Updating ASM to version 9.6,
> 
> Thanks in advance for the reviews,
> Vicente

hi Mandy, thanks for your comments,

> The change looks okay to me. Most of the changes are doc change. I see many files are updated just to remove the empty line at the end of the file - is that intentional, imported from this upgrade?

yes this is intentional, this change somehow aligns with what we do with our sources that's why I kept it 

> 
> Any need to update the copyright header? The new file CheckFrameAnalyzer.java still has the same copyright header years as other files. I assume no need then?

yes there is no need to update them, we never update the year on the copyright of ASM sources

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17453#issuecomment-1911245663


More information about the core-libs-dev mailing list