RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v3]

Kevin Walls kevinw at openjdk.org
Sat Jan 27 12:24:34 UTC 2024


On Fri, 26 Jan 2024 21:06:00 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This mechanically replaces NULL with nullptr in hpp/cpp native files in test native code.  This didn't attempt to change NULL in comments to say null because nullptr is generally the right thing for the comment to say.  It does attempt to change NULL to "null" rather than "nullptr" in strings.  Any changes for "nullptr" to "null" in comments can be changed in a future RFE in a smaller patch. I didn't see any when it was scrolling by to make my script more complicated.
>> 
>> Ran tier1-4 testing.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix nullptr only contained in strings.

That is long.  Hypnotic to read. One very trivial nit, use or ignore as required, but all good that I can see.

-------------

Marked as reviewed by kevinw (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17593#pullrequestreview-1847074612


More information about the core-libs-dev mailing list