RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v5]
Coleen Phillimore
coleenp at openjdk.org
Mon Jan 29 14:26:38 UTC 2024
On Mon, 29 Jan 2024 13:47:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> This mechanically replaces NULL with nullptr in hpp/cpp native files in test native code. This didn't attempt to change NULL in comments to say null because nullptr is generally the right thing for the comment to say. It does attempt to change NULL to "null" rather than "nullptr" in strings. Any changes for "nullptr" to "null" in comments can be changed in a future RFE in a smaller patch. I didn't see any when it was scrolling by to make my script more complicated.
>>
>> Ran tier1-4 testing.
>
> Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision:
>
> - Fix some casts unnecessary with nullptr
> - Fix copyrights
Thanks Kevin, Kim and David for wading through this. If there are other changes we can address them separately preserving your eyeballs. My copyright script was broken so I fixed it. I'll wait for GHA to make sure I didn't break anything before integrating.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17593#issuecomment-1914798074
More information about the core-libs-dev
mailing list