RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v4]
Aleksei Efimov
aefimov at openjdk.org
Wed Jul 3 14:31:22 UTC 2024
On Tue, 2 Jul 2024 16:24:49 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Can I please get a review for this small change? The motivation is that javac does not recognize `package.html` files.
>>
>> The conversion was simple, I used a script to rename the files, append "*" on the left and remove some HTML tags like `<body>` and `<html>`. I did the conversion in place, renaming them in git but with the big amount of change `git` thinks it's a new file.
>>
>> I also added a new `package-info.java` file to `javax.naming.ldap.spi`. I hope that's fine.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> remove two unnecessary tags
The latest changes look good to me
-------------
Marked as reviewed by aefimov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19529#pullrequestreview-2156608099
More information about the core-libs-dev
mailing list