RFR: 8325525: Create jtreg test case for JDK-8325203 [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Wed Jul 3 16:49:20 UTC 2024
On Wed, 3 Jul 2024 04:11:40 GMT, Vanitha B P <duke at openjdk.org> wrote:
>> Created jtreg test case for [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app launched by jpackage launcher is not automatically terminated when the the launcher is terminated.
>
> Vanitha B P has updated the pull request incrementally with one additional commit since the last revision:
>
> 8325525 Addressed review comments
test/jdk/tools/jpackage/apps/ThirdPartyAppLauncher.java line 34:
> 32: ProcessBuilder processBuilder = new ProcessBuilder("regedit");
> 33: Process process = processBuilder.start();
> 34: logger.info("RegEdit id=" + process.pid());
Logging is excessive and not applicable here as it can be redirected. The test shall print the PID to stdout.
test/jdk/tools/jpackage/share/JpackageTest.java line 59:
> 57: @Test
> 58: public static void test() throws Throwable {
> 59: JpackageTest test = new JpackageTest();
There is no need to explicitly call the ctor
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19536#discussion_r1664484472
PR Review Comment: https://git.openjdk.org/jdk/pull/19536#discussion_r1664485737
More information about the core-libs-dev
mailing list