RFR: 8335820: java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java fails due to IllegalArgumentException: hash must be nonzero [v2]

[Adam Sotona]

On Mon, 8 Jul 2024 13:57:20 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed BootstrapMethodEntryImpl::computeHashCode
>
> src/java.base/share/classes/jdk/internal/classfile/impl/BootstrapMethodEntryImpl.java line 79:
> 
>> 77:     static int computeHashCode(MethodHandleEntryImpl handle,
>> 78:                                List<? extends LoadableConstantEntry> arguments) {
>> 79:         return 31 * handle.hashCode() + arguments.hashCode();
> 
> Should we update the algorithm here, as this algorithm processes hash codes of the 2nd last item of arguments and the handle the same, both just multiplied by 31?
> 
> Also need a copyright year update.

Right, BSMEntries are also stored in EntryMap.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20074#discussion_r1668711691