RFR: 8335820: java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java fails due to IllegalArgumentException: hash must be nonzero [v2]

[Chen Liang]

On Mon, 8 Jul 2024 14:14:02 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Class-File API constant pool implementation requires non-zero entry hash code.
>> Unfortunately current implementation computes zero hash code for specific CP entries.
>> 
>> This patch removes invalid and obsolete `AbstractPoolEntry::phiMix` calculation and assures all pool entries have non-zero hash. A regression test of the actual zero-hash `IntegerEntry` has been added. 
>> 
>> All pre-computed hash codes in `BoundAttribute::standardAttribute` are updated.
>> 
>> The patch has no performance effect measurable by any of the actual Class-File API benchmarks.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed BootstrapMethodEntryImpl::computeHashCode

Marked as reviewed by liach (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20074#pullrequestreview-2166140052